Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: get active statement range #16062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

Conversation

ecmadao
Copy link
Collaborator

@ecmadao ecmadao commented May 7, 2025

Before:

If the two statements don't have the blank line between them, for example:

CleanShot 2025-05-07 at 19 33 58@2x

The ranges from the WS is [{startLineNumber: 1, endLineNumber: 3, startColumn: 1, endColumn: 1}, {startLineNumber: 3, endLineNumber: 3, startColumn: 1, endColumn: 11}], and the active cursor is line: 3, column: 6, we cannot get the valid active block.

After:

CleanShot 2025-05-07 at 19 21 56@2x
CleanShot 2025-05-07 at 19 25 11@2x

@ecmadao ecmadao requested a review from a team as a code owner May 7, 2025 11:36
@cla-bot cla-bot bot added the cla-signed label May 7, 2025
@ecmadao ecmadao changed the title fix: get active range fix: get active statement range May 7, 2025
@ecmadao ecmadao requested a review from boojack May 7, 2025 11:36
@ecmadao ecmadao merged commit 41385bc into bytebase:main May 7, 2025
10 checks passed
@ecmadao ecmadao deleted the fix/active-range branch May 8, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants