Feature-gate test-programs#600
Merged
kubkon merged 1 commit intobytecodealliance:masterfrom Nov 21, 2019
Merged
Conversation
c31036b to
05ff80e
Compare
joshtriplett
approved these changes
Nov 19, 2019
05ff80e to
8b68a14
Compare
This commit feature-gates `test-programs` as a workaround for `cargo test` not allowing for optional dev-dependencies. This commit addresses bytecodealliance#595.
8b68a14 to
b2fddf3
Compare
Member
Author
kubkon
pushed a commit
to kubkon/wasmtime
that referenced
this pull request
Nov 21, 2019
This commit fixes bugs in enabling feature-gating of `test-programs` which was introduced in bytecodealliance#600. It turns out, bytecodealliance#600 accidentally disabled `test-programs` from ever running, and this commit fixes that.
This was referenced Nov 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit feature-gates
test-programsas a workaround forcargo testnot allowing for optional dev-dependencies.This commit addresses #595.