internal: fix MaxSizeSubjectsListForLog off-by-one when maxToDisplay is 0 - #7970
Open
mohammed90 wants to merge 2 commits into
Open
internal: fix MaxSizeSubjectsListForLog off-by-one when maxToDisplay is 0#7970mohammed90 wants to merge 2 commits into
MaxSizeSubjectsListForLog off-by-one when maxToDisplay is 0#7970mohammed90 wants to merge 2 commits into
Conversation
…is 0 The loop appended before checking the length, so with maxToDisplay=0 one domain leaked into the output before the break check. Reorder so the length check comes first. Signed-off-by: Mohammed Al Sahaf <[email protected]>
steadytao
requested changes
Sep 2, 2026
steadytao
reviewed
Sep 2, 2026
Comment on lines
5
to
8
| // MaxSizeSubjectsListForLog returns the keys in the map as a slice of maximum length | ||
| // maxToDisplay. It is useful for logging domains being managed, for example, since a | ||
| // map is typically needed for quick lookup, but a slice is needed for logging, and this | ||
| // can be quite a doozy since there may be a huge amount (hundreds of thousands). |
Member
There was a problem hiding this comment.
Suggested change
| // MaxSizeSubjectsListForLog returns up to maxToDisplay keys from subjects. | |
| // If any keys are omitted, it appends one additional entry summarising the | |
| // omitted count. This bounds the number of subject names placed in the log | |
| // while making truncation explicit. |
steadytao
requested changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop appended before checking the length, so with
maxToDisplay=0one domain leaked into the output before the break check. Reorder so the length check comes first.Assistance Disclosure
Test was generated by copilot/Claude 4.7; fixed by the same.
Related to #7227