caddyhttp: fix randString sameCase dictionary to match its docs - #7972
Open
mohammed90 wants to merge 2 commits into
Open
caddyhttp: fix randString sameCase dictionary to match its docs#7972mohammed90 wants to merge 2 commits into
mohammed90 wants to merge 2 commits into
Conversation
The doc comment says randString excludes confusing characters like I, l, 1, 0, O. When sameCase is true, uppercase letters and the characters l and o should be excluded. But the sameCase dictionary still contained '0'. Drop it. Signed-off-by: Mohammed Al Sahaf <[email protected]>
steadytao
requested changes
Sep 2, 2026
| dict := []byte("abcdefghijkmnopqrstuvwxyzABCDEFGHJKLMNPQRTUVWXY23456789") | ||
| if sameCase { | ||
| dict = []byte("abcdefghijkmnpqrstuvwxyz0123456789") | ||
| dict = []byte("abcdefghijkmnpqrstuvwxyz123456789") |
Member
There was a problem hiding this comment.
The documented ambiguous-character exclusions include both 0 and 1. This removes 0 but still emits 1 while the mixed-case dictionary correctly starts at 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doc comment says
randStringexcludes confusing characters like I, l, 1, 0, O. WhensameCaseis true, uppercase letters and the characters l and o should be excluded. But thesameCasedictionary still contained '0'. Drop it.Assistance Disclosure
Test was generated by copilot/Claude 4.7; fixed by the same.
Related to #7227