caddy: pass ListenQUIC options as a struct - #7976
Open
tomholford wants to merge 1 commit into
Open
Conversation
This was referenced Aug 31, 2026
tomholford
marked this pull request as ready for review
August 31, 2026 05:53
tomholford
force-pushed
the
listenquic-options
branch
from
September 1, 2026 15:05
e813cd7 to
1ec7599
Compare
steadytao
approved these changes
Sep 2, 2026
steadytao
left a comment
Member
There was a problem hiding this comment.
I am quite happy with this.
Member
|
Technically this is a breaking API change, but I assume nobody should have had a reason to use this in plugins? Probably fine. |
Member
|
Yeah, I feel they're improperly handling if they are anyways. Could be worth a small note in release though, even just a #PR. |
tomholford
force-pushed
the
listenquic-options
branch
3 times, most recently
from
September 9, 2026 13:30
7f7d978 to
b69c418
Compare
mholt
approved these changes
Sep 9, 2026
mholt
left a comment
Member
There was a problem hiding this comment.
This is better, and yeah I don't think anyone is using this (if so, easy and obvious to fix).
tomholford
force-pushed
the
listenquic-options
branch
from
September 10, 2026 18:28
b69c418 to
9ecb1bc
Compare
Collapse the TLS config, packet-conn wrappers, and Allow0RTT arguments into ListenQUICOptions so the signature matches Listen's ctx/portOffset/ ListenConfig prefix. Zero-value opts keep the historical default of allowing 0-RTT. The API remains experimental.
tomholford
force-pushed
the
listenquic-options
branch
from
September 11, 2026 15:38
9ecb1bc to
e9c5f7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapse ListenQUIC's TLS config, packet-conn wrappers, and Allow0RTT
arguments into ListenQUICOptions per feedback by mholt on #7669
First in a PR stack, as a pre-req for experimental webtransport passthrough (#7669)
AI-assisted (Grok 4.6 / Delta). I built and tested this e2e as part of validation of #7669. WOMM