Edit some documentation and added text field to configure IP#12
Merged
Conversation
YiqinZhao
reviewed
Sep 12, 2024
YiqinZhao
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution. I added comments.
YiqinZhao
reviewed
Sep 13, 2024
| // const string serverURL = "http://192.168.1.139:8500"; | ||
| const string serverURL = "http://192.168.1.219:8500"; | ||
| inputField.text = serverURL; | ||
| const string initServerURL = "192.168.1.219"; |
Member
There was a problem hiding this comment.
Will these default values be displayed on the screen? If so, we should use text placeholders like server address and server port
Contributor
Author
There was a problem hiding this comment.
Oh yeah, I'll add that
Contributor
Author
There was a problem hiding this comment.
Oh do you want to use the placeholders instead of default values? Or should I display the placeholders when the default values are used?
Member
There was a problem hiding this comment.
Display placeholders when default values are used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.