Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Client device modifications #14

Merged
YiqinZhao merged 5 commits into
cake-lab:mainfrom
legoeruro:main
Sep 18, 2024
Merged

Client device modifications #14
YiqinZhao merged 5 commits into
cake-lab:mainfrom
legoeruro:main

Conversation

@legoeruro

Copy link
Copy Markdown
Contributor

Sorry, I forgot to commit and push before the last PR.

@YiqinZhao YiqinZhao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, see the comments

Comment thread unity/Assets/Scripts/ARFlow/ARFlowClient.cs Outdated
Comment thread unity/Assets/Scripts/ARFlowXiheDemo.cs Outdated
guid: a85ce1c6384d24c2a8e016dbf92ebe5c
- enabled: 1
path: Assets/Scenes/XiheDemo.unity
guid: 16bf2390a4afb41c48a28fbea06c2cdd

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the default scene as DeviceData.unity on the main branch. Let's revert these changes back.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'll make sure of this in later changes

@YiqinZhao YiqinZhao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YiqinZhao YiqinZhao merged commit a5690ff into cake-lab:main Sep 18, 2024
@YiqinZhao YiqinZhao added WPI Projects created by WPI students. MQP Project related to WPI MQP projects. labels Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MQP Project related to WPI MQP projects. WPI Projects created by WPI students.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants