Update TableLocator Interface to add more flexibility #14499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…different implementations
Codecov Report
@@ Coverage Diff @@
## 3.x #14499 +/- ##
=========================================
Coverage 90.98% 90.99%
Complexity 14093 14093
=========================================
Files 525 525
Lines 36284 36284
=========================================
+ Hits 33014 33016 +2
+ Misses 3270 3268 -2
Continue to review full report at Codecov.
|
|
Is this something that is ment to go into 4.x too? Because when mapped to real type declarations this would be invalid, as return type covariance is only available as of PHP 7.4 |
|
@ndm That's unfortunate. Changing the typing on the current interface would break compatibility 😢 |
|
We could add it to a wiki page tracking changes we can make when PHP 7.4 is the minimum version. |
2 tasks
|
Added to 5.0 roadmap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14495
This change creates more flexibility in the interface by allowing custom Locator implementations such as the use-case shown in #12014
It should actually make no difference to the core framework code as
\Cake\ORM\Tablealready implements\Cake\Datasource\RepositoryInterface.The only downside I can think of, might be the stand-alone ORM package, as I can't see the interface in there.