managed nested validation context #18212
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Mar 3, 2025
There was a problem hiding this comment.
Thanks for putting this together. Your changes have caused a few existing tests to fail, and before we can get this merged in we'll need to add some additional tests. If you need a hand with tests I can help, but I could use a hand in understanding how you see this logic being used.
| * @return array<string, mixed> | ||
| */ | ||
| protected function _processRules(string $field, ValidationSet $rules, array $data, bool $newRecord): array | ||
| protected function _processRules(string $field, ValidationSet $rules, mixed $value, array $context): array |
There was a problem hiding this comment.
We generally reserved changes in protected methods for minor releases as they can cause application failures.
There was a problem hiding this comment.
I have a custom validator overriding this method.
There was a problem hiding this comment.
probably the only method for not overriding the _processRules signature is to implement a stack of contexts and retrieve it int the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added to the validator context, information about parent data for nested validator
this pull request is related to issue #17705