Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Only enforce requireFieldPresence on property access. #18216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: 5.next
Choose a base branch
from
Open

Only enforce requireFieldPresence on property access. #18216

wants to merge 6 commits into from

Conversation

nicosp
Copy link
Contributor

@nicosp nicosp commented Feb 28, 2025 •
edited
Loading

  • Make requireFieldPresence only affect property access.
  • Introduce getExistingOrFail() if we want strict checks unconditionally.

Issue: #18211

@dereuromark dereuromark added this to the 5.3.0 milestone May 6, 2025
@nicosp nicosp force-pushed the improve-require-field-presence branch from 37d4f86 to 4a6b581 Compare May 13, 2025 12:19
@nicosp nicosp marked this pull request as ready for review May 13, 2025 12:26
dereuromark
dereuromark reviewed May 20, 2025
View reviewed changes
@nicosp nicosp force-pushed the improve-require-field-presence branch from 2514fe7 to 01d0447 Compare May 20, 2025 12:23
@nicosp nicosp requested a review from dereuromark May 20, 2025 12:28
dereuromark
dereuromark reviewed May 20, 2025
View reviewed changes
@nicosp nicosp requested a review from dereuromark May 21, 2025 06:20
@nicosp
Copy link
Contributor Author

nicosp commented Jun 3, 2025

@dereuromark Is this ok?

@dereuromark
Copy link
Member

From my side yes
getEx() is maybe still a bit questionable as name
but otherwise.

@nicosp
Copy link
Contributor Author

nicosp commented Jun 3, 2025

From my side yes getEx() is maybe still a bit questionable as name but otherwise.

I am not sure what's best here. I though about _get but it is very easily confused with __get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereuromark dereuromark Awaiting requested review from dereuromark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nicosp @dereuromark