Backport: Make NullEngine return the original keys like other engines #18251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADmad
reviewed
Mar 25, 2025
Comment on lines
+65
to
+71
| $result = []; | ||
|
|
||
| foreach ($keys as $key) { | ||
| $result[$key] = $default; | ||
| } | ||
|
|
||
| return $result; |
There was a problem hiding this comment.
Suggested change
| $result = []; | |
| foreach ($keys as $key) { | |
| $result[$key] = $default; | |
| } | |
| return $result; | |
| return array_fill_keys($keys, $default); |
There was a problem hiding this comment.
Keeping foreach since $keys is an iterable.
|
Best to not maintain 2 PRs here, prioritize the first (5.x) and once merged you can port it (with all changes then done on top) here. |
|
Since #18250 got reviewed and approved, this PR does not need any changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18250