Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix deprecation error for __wakeup() usage on PHP 8.5 #18907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2025
Merged

Fix deprecation error for __wakeup() usage on PHP 8.5 #18907

merged 2 commits into from
Sep 13, 2025
+18 −16

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Sep 13, 2025 •
edited
Loading

We'll need mockery and phpunit to also address this deprecation, for CI to pass on PHP 8.5.

@ADmad ADmad added this to the 5.2.8 milestone Sep 13, 2025
@ADmad ADmad marked this pull request as draft September 13, 2025 07:20
@ADmad ADmad marked this pull request as ready for review September 13, 2025 09:04
@ADmad
Copy link
Member Author

ADmad commented Sep 13, 2025 •
edited
Loading

The remaining errors are due to 2 reasons:

  1. Creating mock for PDOException through phpunit's mock builder:
    It's because Exception has a "hidden" __wakeup(). Sebastian has already acknowledge the issue and stated the doubles creation will be updated to not include __wakeup() and __sleep() on PHP 8.5
    Update: I got rid of the mocked PDOException usage.

  2. Creating mocks with mockery due to the Mock::__wakeup() method.
    Awaiting response for related ticket on mockery's repo.

@markstory markstory merged commit 4dcc62b into 5.x Sep 13, 2025
14 of 15 checks passed
@markstory markstory deleted the php8.5 branch September 13, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@ADmad @markstory