3.0 request detector #3031
3.0 request detector #3031
Conversation
|
Looks good to me. |
|
👍 |
| @@ -128,12 +128,6 @@ class Request implements \ArrayAccess { | |||
| 'ssl' => array('env' => 'HTTPS', 'value' => 1), | |||
| 'ajax' => array('env' => 'HTTP_X_REQUESTED_WITH', 'value' => 'XMLHttpRequest'), | |||
| 'flash' => array('env' => 'HTTP_USER_AGENT', 'pattern' => '/^(Shockwave|Adobe) Flash/'), | |||
| 'mobile' => array('env' => 'HTTP_USER_AGENT', 'options' => array( | |||
There was a problem hiding this comment.
What if we move this list to app.php? I'm still against completely removing the mobile detector as it is quite useful.
There was a problem hiding this comment.
That would be just moving the problem to a different location. The app would then have that potentially outdated list.
There was a problem hiding this comment.
Maybe we can add this lib to the requires? https://github.com/serbanghita/Mobile-Detect
There was a problem hiding this comment.
Or as "suggests" instead? I would rather not force everyone to download that lib. If for eg. you are making a webservice API you might not need it.
There was a problem hiding this comment.
I think it will be a big mistake to ship without something as useful as a mobile detector
There was a problem hiding this comment.
Okay then merging this so I can process with patch for app.
There was a problem hiding this comment.
I'd prefer to have it the MobileDetect lib only as a suggest.
But if it has to be require, then in the app.
There was a problem hiding this comment.
@ravage84 We can't include any defaults for is(mobile) / is(tablet) without the require.
Refs #2546