feat: Add rerouting to AssignmentReasonRecorder
#19252
Conversation
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/12/25)1 reviewer was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
| @@ -467,6 +469,7 @@ const NewRoutingManager = ({ | |||
| // TODO: Long term, we should refactor handleNewBooking and use a different route specific for this purpose, | |||
| createBookingMutation.mutate({ | |||
| rescheduleUid: booking.uid, | |||
| rescheduledBy: session?.data?.user?.email, | |||
There was a problem hiding this comment.
Need to track who is calling the reroute
| isRerouting, | ||
| reroutedByEmail, |
There was a problem hiding this comment.
We can reuse the logic that we use when recording the initial routing. That way we can see what attributes changed.
E2E results are ready! |
|
This PR is being marked as stale due to inactivity. |
|
This PR is being marked as stale due to inactivity. |
| @@ -469,6 +471,7 @@ const NewRoutingManager = ({ | |||
| // TODO: Long term, we should refactor handleNewBooking and use a different route specific for this purpose, | |||
| createBookingMutation.mutate({ | |||
| rescheduleUid: booking.uid, | |||
| rescheduledBy: session?.data?.user?.email ?? undefined, | |||
There was a problem hiding this comment.
Shouldn't we error early if session is nullish, because rerouting can't be done by a non-logged in user.
Doing this change make it feel like non-logged in user could do re-routing
| const userQuery = await prisma.user.findFirst({ | ||
| where: { | ||
| email: reroutedByEmail, | ||
| }, | ||
| select: { | ||
| id: true, | ||
| }, | ||
| }); | ||
|
|
||
| if (userQuery) { | ||
| reroutedByUserId = userQuery.id; | ||
| } |
There was a problem hiding this comment.
We should use UserRepository
| reasonString: attributeValues.join(", "), | ||
| reasonEnum: isRerouting ? AssignmentReasonEnum.REROUTED : AssignmentReasonEnum.ROUTING_FORM_ROUTING, | ||
| reasonString: `${ | ||
| reroutedByUserId ? `Rerouted by user: ${reroutedByUserId}` : "" |
There was a problem hiding this comment.
As this reason would be shown to users, so maybe we should show the email here?
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?