feat: Salesforce Event Type App v3 designs #21100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
| ref?: React.Ref<HTMLDivElement>; | ||
| className?: string; | ||
| }) => { | ||
| const [animateRef] = useAutoAnimate<HTMLDivElement>(); |
There was a problem hiding this comment.
Unused ref variable 'animateRef' is assigned but never used in the component's JSX.
There was a problem hiding this comment.
Mrge it is used three lines below what are you on about
apps/ui-playground/content/design/components/section.withIcon.tsx
Outdated
Show resolved
Hide resolved
sean-brydon
commented
May 3, 2025
| }> | ||
| <div> | ||
| <div> | ||
| {/* {app.credentialOwner && !isPlatform && ( |
There was a problem hiding this comment.
This wasnt in designs anywhere - not sure where we need to put this or how important it is? @ciaranha
sean-brydon
commented
May 3, 2025
There was a problem hiding this comment.
Fixes select to match our input sizes
Udit-takkar
reviewed
May 5, 2025
eunjae-lee
approved these changes
May 5, 2025
Graphite Automations"Add ready-for-e2e label" took an action on this PR • (05/05/25)1 label was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
alishaz-polymath
pushed a commit
that referenced
this pull request
May 9, 2025
* section component * more section UI * wip * core components styled * all components using sections * match icons to figma * small inputs * fix select small to be the same as small text * center flex rows * enforce inputs to be full spanning grid * tidy up section container for single inputs * fix select and i18n * wip * install available apps * raw heading * app install card * fix app logos width x height * fix gap * match design for other button * fix prop name * push i18n string * fix doc snippets * fix docs * chore: remove yarn.lock changes --------- Co-authored-by: Udit Takkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes: #18538
Visual Demo
BEFORE:
AFTER
Salesforce
Other apps (will update with section components in a follow up PR)
![Uploading CleanShot 2025-05-03 at 21.46.53.png…]()
UI playground docs on section
New V3 designs have seen this pattern a lot so why not make it as re-usable as possible.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Install salesforce to an event type
Add some faux data
Checklist
Summary by mrge
Added new Section UI components and updated the Salesforce Event Type app to use the new V3 designs for a more organized and consistent settings experience.