You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Cap default Vitest concurrency at two workers so three concurrent Codex worktrees leave CPU headroom for test subprocesses, simulators, and the OS on a 12-core development host.
Use the same shared cap for affected coverage runs. The subprocess-stub project remains serialized at one worker.
Scope: 5 files; test-runner configuration and its regression coverage only.
Validation
The full unit bundle passed under three concurrent Codex workers: 680 files and 5,913 tests in 221.81s. Node integration passed 55 tests with 8 live-device cases skipped, and provider integration passed 156 tests. Affected coverage, integration progress, replay compatibility, formatting, lint, typecheck, layering, fallow, build, and package verification passed.
Red-before proof: removing only the new top-level cap makes the config regression fail with undefined !== 2; restoring it passes.
The package smoke initially timed out in the host Apple inventory probe after broad validation but passed in isolation. The final affected gate passed with xcrun unavailable, matching the package check stated device-free/offline contract.
Exact-head review at a5e210386: code-review clean. The shared maxWorkers=2 cap is correctly inherited by ordinary Vitest projects while the subprocess-stub project remains serialized; affected coverage reuses the same constant without duplicating or narrowing suites. Both regressions are non-vacuous, and the full-unit/concurrent-worktree validation is proportionate for this test-runner-only change. No device evidence is required. Current remaining checks are still running, with no confirmed failure; ready-for-human from a code-review standpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cap default Vitest concurrency at two workers so three concurrent Codex worktrees leave CPU headroom for test subprocesses, simulators, and the OS on a 12-core development host.
Use the same shared cap for affected coverage runs. The subprocess-stub project remains serialized at one worker.
Scope: 5 files; test-runner configuration and its regression coverage only.
Validation
The full unit bundle passed under three concurrent Codex workers: 680 files and 5,913 tests in 221.81s. Node integration passed 55 tests with 8 live-device cases skipped, and provider integration passed 156 tests. Affected coverage, integration progress, replay compatibility, formatting, lint, typecheck, layering, fallow, build, and package verification passed.
Red-before proof: removing only the new top-level cap makes the config regression fail with undefined !== 2; restoring it passes.
The package smoke initially timed out in the host Apple inventory probe after broad validation but passed in isolation. The final affected gate passed with xcrun unavailable, matching the package check stated device-free/offline contract.
No command behavior, docs, or skills changed.