Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(batch): preserve typed error recovery signals - #1761

Merged
thymikee merged 4 commits into
callstack:mainfrom
cosin2077:agent/fix-batch-error-signals
Aug 12, 2026
Merged

fix(batch): preserve typed error recovery signals#1761
thymikee merged 4 commits into
callstack:mainfrom
cosin2077:agent/fix-batch-error-signals

Conversation

@cosin2077

@cosin2077 cosin2077 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Preserve structured recovery signals from a failing batch step.

DaemonError can carry retriable and supportedOn, but runBatch() rebuilt the failing step error without forwarding either field. That meant the same underlying failure lost machine-readable recovery guidance when invoked through batch.

This change:

  • forwards retriable and supportedOn when present;
  • keeps those keys absent when the underlying error does not classify them;
  • uses the canonical DaemonError type instead of a narrower local copy;
  • adds regression coverage for both preservation and absence semantics.

Test plan

  • Added unit coverage for preserving retriable / supportedOn.
  • Added coverage that unknown recovery signals remain absent.
  • Full repository gates are pending GitHub Actions approval for this fork PR.

@thymikee

Copy link
Copy Markdown
Member

Reviewed exact head 6cc05f7. Using the canonical DaemonError shape and conditionally copying retriable/supportedOn fixes the real batch-wrapper truncation while keeping unknown signals absent. The production route remains compatible with generic request finalization, the regression is non-vacuous, touched-file topology is healthy, and this pure wire-composition fix does not require device evidence. No source issue remains.

This is not readiness-ready yet: the PR body is still the untouched template. Please document the motivating recovery-signal loss, concise summary, validation with red-before evidence, and the two-file scope. GitHub also reports zero checks for this exact head, so it cannot yet be called CI-green. Keep draft until the body and authoritative checks are complete.

No ready-for-human label applied.

@cosin2077 cosin2077 changed the title Agent/fix batch error signals fix(batch): preserve typed error recovery signals Aug 12, 2026
@cosin2077
cosin2077 marked this pull request as ready for review August 12, 2026 05:16
@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Aug 12, 2026
@thymikee

Copy link
Copy Markdown
Member

Readiness update for unchanged exact head 6cc05f72: the title, substantive body, and draft-state blockers are resolved. The reviewed change remains code-clean and ready for human review; no device evidence is needed for this pure error-wire composition fix.

The only material blocker is owner approval and completion of full authoritative CI: GitHub still reports zero checks. Please also finish the body evidence with explicit two-file scope accounting and the actual red-before result, rather than only stating that coverage was added.

@thymikee
thymikee merged commit 52ef4ca into callstack:main Aug 12, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants