You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Android recording-session generic commands and type now continue when blocking-dialog readiness inspection fails, while returning a bounded warning with the normalized inspection error and actionable hint. Existing response warnings are appended rather than replaced. The warning is carried from the typed recovery result through both generic and type response paths.
Validation
The focused regression suite was red against origin/main: 3 failed, 2 passed.
The focused regression suite is green after the fix: 3 files, 5 tests passed.
The updated truncation test uses multiline, over-limit message and hint inputs and asserts whitespace normalization plus exact 240-character bounded fields ending in an ellipsis.
pnpm check:affected --run passed for the implementation; the review-only test change also passes pnpm check:fallow --base origin/main and the focused suite.
Exact-head live Android verification at 17a913bb6 used the com.callstack.agentdevicelab test app on emulator emulator-5554 with androidSnapshot.backend=android-helper before the run and an app-scoped adb screenrecord.
With the bundled snapshot helper temporarily unavailable, generic home returned success: true with the readiness warning and pnpm build:android hint; type also returned success: true, typed 6 characters, and returned the same composed warning.
CHANGELOG.md was updated. No skills or ADR guidance changed because the issue scope is runtime behavior and changelog coverage.
Reviewed exact head ceb6d0ff9a630dfc2d1342bfce942d1ca4fe17f2.
The bounded-warning regression is currently vacuous: both the message and hint are below the 240-character limit, and warning.length < 800 still passes if boundAndroidWarningText is removed. Please drive this test with over-limit, multiline message and hint values and assert whitespace normalization plus truncation/ellipsis at the declared ceiling, so reverting the bound makes the test red. Keep the short actionable pnpm build:android hint assertion separately if useful.
Before merge readiness, also attach exact-head live Android evidence from a recording session with readiness inspection deliberately unavailable, proving both a generic command and type still execute and return the composed actionable warning. The PR currently states that no live Android verification was run.
The bounded-warning regression now uses multiline, over-limit message and hint values, rejects tabs/newlines/repeated spaces, and requires each bounded field to be exactly 239 characters plus an ellipsis.
Exact-head live Android verification on emulator-5554 completed in an app-scoped adb screenrecord: generic home returned success with the readiness warning and pnpm build:android hint; type returned success and typed 6 characters with the same warning.
The snapshot helper was restored and the verification session was closed cleanly.
Re-reviewed exact head 17a913bb6e8488b1d776c5e9fb7bcbdbea4ad03d: clean. The bounded-warning regression now uses over-limit multiline inputs and proves normalization, truncation, and the declared ceiling; the exact-head Android recording evidence exercises both generic and type fail-open routes with inspection unavailable. All 28 checks are green, including Android/iOS/Linux/macOS smoke, and GitHub reports the branch clean and mergeable. Ready for human review and merge.
Preview removed because the pull request was closed.
2026-08-20 13:19 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1895
Android recording-session generic commands and
typenow continue when blocking-dialog readiness inspection fails, while returning a bounded warning with the normalized inspection error and actionable hint. Existing response warnings are appended rather than replaced. The warning is carried from the typed recovery result through both generic andtyperesponse paths.Validation
pnpm check:affected --runpassed for the implementation; the review-only test change also passespnpm check:fallow --base origin/mainand the focused suite.17a913bb6used thecom.callstack.agentdevicelabtest app on emulatoremulator-5554withandroidSnapshot.backend=android-helperbefore the run and an app-scopedadb screenrecord.homereturnedsuccess: truewith the readiness warning andpnpm build:androidhint;typealso returnedsuccess: true, typed 6 characters, and returned the same composed warning.CHANGELOG.md was updated. No skills or ADR guidance changed because the issue scope is runtime behavior and changelog coverage.