Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: calibrate iOS scroll execution - #1905

Merged
thymikee merged 1 commit into
mainfrom
fix/ios-scroll-calibration
Aug 20, 2026
Merged

fix: calibrate iOS scroll execution#1905
thymikee merged 1 commit into
mainfrom
fix/ios-scroll-calibration

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

Calibrates default iOS scrolling for dense settings-style screens and makes edge verification follow the viewport-centered gesture instead of an unrelated nested scroll container.

The iOS amount and shared mobile duration now come from one cross-runtime parity contract, explicit distance/timing remains unchanged, Swift runner defaults are command-tested, and recording telemetry reflects each platform transport. Explicit point-target edge semantics are preserved. Scope is 17 files within the scroll command family.

Validation

  • Live iOS Simulator verification on a nested settings screen: the default scroll repeatedly reached the intended intermediate section, and target-less scroll top --settle correctly recognized the viewport was already at the edge without scrolling the nested control.
  • pnpm check:affected --run: 4,562 tests passed; changed-line coverage 100%; formatting, lint, typecheck, layering, fallow, build, and XCTest selection passed.
  • Exact iOS Simulator and macOS XCUITest runner builds passed.
  • Regression tests were proven red against the prior default and prior broad-container selection, then green after the fix.
  • Adversarial review completed with no remaining actionable findings.

Docs and skills are unchanged because command syntax and workflow guidance did not change.

@github-actions

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 2.33 MB 2.33 MB +504 B
JS gzip 765.6 kB 765.8 kB +167 B
npm tarball 890.3 kB 890.8 kB +448 B
npm unpacked 3.10 MB 3.10 MB +1.4 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.7 ms 26.9 ms +0.3 ms
CLI --help 67.8 ms 67.8 ms +0.0 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/script-source-bundle.js +243 B +76 B
dist/src/internal/daemon.js +90 B +26 B
dist/src/registry.js 0 B +4 B
dist/src/session2.js 0 B +1 B
dist/src/runtime.js 0 B -1 B

@thymikee

Copy link
Copy Markdown
Member Author

✅ Ready for human — reviewed at 3624fbaf9df3a264e13552a788f90e8253f7bfaf. The calibrated iOS defaults reach the fused runner command without changing explicit distance/timing or macOS/tvOS behavior, and edge verification now follows the viewport-centered gesture rather than an off-center nested scroller. The regression and exact-head simulator evidence are non-vacuous, size remains below the scrutiny threshold, the PR is mergeable, and all checks—including iOS smoke and Swift runner XCTests—are green.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Aug 20, 2026
@thymikee
thymikee merged commit fed7251 into main Aug 20, 2026
28 checks passed
@thymikee
thymikee deleted the fix/ios-scroll-calibration branch August 20, 2026 13:19
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-20 13:20 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant