You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make iOS snapshot geometric actionability one backend-independent predicate across recursive tree, query sweep, private AX, and collapsed-tab acquisition.
Remove the XCTest runner later-node occlusion scan and its obsolete flatten/range/type-gate helpers while preserving intentional direct/raw interaction paths.
Keep daemon snapshot occlusion as the sole owner of structured covered state and retain interactionBlocked: "covered" consumer behavior.
Add focused regression coverage and changed-path live evidence for the distinction between geometric hittable and daemon occlusion.
Validation
Red before the fix: the focused regular-presentation XCTest selected one test and failed three assertions for a covered button, labeled image, and disabled button.
Live on existing booted iPhone 17 Pro F7D6F9A4-4FCC-4DD7-AC0B-3280C9319CB9: regular and raw direct payloads both reported automation-press as hittable true with no interactionBlocked, snapshotQuality.backend tree, and XCTest backend diagnostics present (4/5). The changed lifecycle route passed its regular/raw app-switcher assertions and screenshot evidence. All scoped sessions were closed and isolated daemons cleaned.
Final pnpm check:affected --run passed all runnable checks; native/device and coverage lanes remain GitHub-authoritative. The broad lifecycle run later reached the existing simulator observability check and stopped because CPU sampling is unavailable on simulators; that unrelated failure was not pursued.
Reviewed exact head 1bfb9291e: code-clean and merge-ready. All acquisition paths now derive snapshot hittable from enabled geometry and effective viewport clipping, while daemon occlusion remains the sole producer of structured covered state. The exact-head app-switcher live run covers regular and raw snapshots, all CI is green, and size is neutral-to-smaller. Merge-order note: draft #1930 still describes tree/query hittability as hit-tested and private AX as approximated; after #1933 lands, #1930 must rebase and update that registry/help contract to this backend-independent geometric semantics before it can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation