Tidy up SSL connection to fix deprecation warnings #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5e43f39)
russella-acm
approved these changes
Dec 7, 2024
Contributor
There was a problem hiding this comment.
LGTM - brilliant as always @mikemanger - thank you for fixing this. We really appreciate all the work you've done to make this wrapper better.
To test this change we:
✔️ Ran the unit tests, they all pass
✔️ Ran a sample program using the code in this PR, that passed
✔️ Ran tox, below is a picture of the before and after showing that the deprecation warning has been eliminated.
Before/After - Left/Right
We will release this in a new version (9.0.1)
We will take a look at review the issues which we have not paid proper attention to, and see if we can address them. Of course, we welcome any feedback or help along the way to keep improving this API wrapper. A big thank you for all your contributions 🥇
AlexisT-CM
pushed a commit
that referenced
this pull request
Jan 23, 2025
Tidy up SSL connection to fix deprecation warnings
AlexisT-CM
pushed a commit
that referenced
this pull request
Jan 23, 2025
Tidy up SSL connection to fix deprecation warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some python 2 checks and fixes deprecation warnings on python 3.10 and above. Fixes #85
I feel the
VerifiedHTTPSConnectionclass should probably be dropped in favour of using urllib3.connection.HTTPSConnection as a dependency - the code in this repository appears to be based on a much earlier version of this class. I don't think it is quite a drop in replacement as we'd need to set the CA file included in this repository.