Conversation
|
letFunny
left a comment
There was a problem hiding this comment.
This looks good, thank you! I was reluctant to allow this in the first place to prevent people from adding this blindly to their CI scripts and using outdated and non-secure image without even knowing about it. Thinking about it some more, that could happen even with one flag as unstable is unlikely to be used for production systems anyway.
I am also tempted to have some tests but I don't think it makes a lot of sense. We are testing both flags individually already using spread and I don't want to have unrelated tests just to combine all flags available in the CI even if not relevant for the case at hand.
Yeah, thought about it but wanted to keep the PR small and wait for the feedback. I have tested locally and 1) only the More than happy to add specific multi-flag tests if requested though. |
|
We are already testing them individually. Testing the combination specifically might make sense but it might also be seen as testing the go-flags library. |
niemeyer
left a comment
There was a problem hiding this comment.
PR looks fine, and idea is correct. Just a question in terms of conventions: I imagined that we'd be supporting something like --ignore=unmaintained,unstable, but I'm not sure if we have precedence in either direction.
@letFunny Do we have anything analogous in either direction?
|
In either case, we can do both. I'm merging this for now. |
Allows passing multiple
--ignoreflags, for examplechisel cut --release=./ --root=rootfs --ignore=unmaintained --ignore=unstablelibc6_libs`.Proposal for addressing this issue/PR in chisel-releases.
TLDR; in
chisel-releasescli we want a general cut command which will try to cut both unmaintained and unstable releases (at the time of writing this is 20.04 and 25.10 respectively). As opposed to figuring out the logic dynamically we could just always pass all the ignore flags.I would also argue that this is the intuitive behavior users would expect + allows us to trivially expand into any future conditions we might want to ignore.