slicer/test: Set archive options from release#82
Merged
niemeyer merged 1 commit intocanonical:mainfrom Sep 17, 2023
Merged
Conversation
Contributor
Author
|
This PR depends on #81 |
Currently testArchive.Options() returns archive.Options with only the Arch field set. In future we would like to extend testArchive to behave differently based on its chisel.yaml definition. Initialize archive.Options from setup.Release and store it in the testArchive structure for each archive defined in chise.yaml.
9aad663 to
9cae335
Compare
rebornplusplus
approved these changes
Sep 1, 2023
rebornplusplus
left a comment
There was a problem hiding this comment.
LGTM. You could probably add the Simple label to this one.
Just for incase you plan to use this in the commit, the last file name has a typo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently testArchive.Options() returns archive.Options with only the
Arch field set. In future we would like to extend testArchive to behave
differently based on its chisel.yaml definition.
Initialize archive.Options from setup.Release and store it in the
testArchive structure for each archive defined in chise.yaml.