Tests: improve coverage of Network #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #515 +/- ##
==========================================
+ Coverage 68.86% 70.17% +1.31%
==========================================
Files 26 26
Lines 3112 3112
Branches 526 526
==========================================
+ Hits 2143 2184 +41
+ Misses 831 800 -31
+ Partials 138 128 -10 |
6fbb82a to
37a28d6
Compare
erlend-aasland
commented
Jul 11, 2024
Comment on lines
+49
to
+51
| # Will err because we're not connected to a real network. | ||
| with self.assertLogs(level=logging.ERROR): | ||
| self.network.add_node(2, SAMPLE_EDS, upload_eds=True) |
There was a problem hiding this comment.
This test can be enhanced for example by mocking canopen.sdo.SdoClient.open to return a pre-filled StringIO buffer.
acolomb
approved these changes
Aug 6, 2024
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.