Fix issues in storage #4272
Merged
Fix issues in storage #4272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsrdn
approved these changes
Sep 6, 2023
|
bors merge |
casperlabs-bors-ng bot
added a commit
that referenced
this pull request
Sep 6, 2023
4272: Fix issues in storage r=Fraser999 a=Fraser999 This PR fixes two separate issues: * a historical synced block with no deploys would have no entry written for it in the `transfers_db`, causing the JSON-RPC `chain_get_block_transfers` to report the block's transfers as `null` rather than `[]` * for a block with a non-zero number of successful transfers, if its execution results were put to storage more than once, the initial valid entry in the `transfers_db` would be overwritten with an invalid empty collection, causing the JSON-RPC `chain_get_block_transfers` to report the block's transfers as `[]` rather then the correct value Th fix is to have `Storage` reconstitute the correct value when reading from `transfers_db` if it encounters a missing value or an empty collection, and store the corrected value before returning it. The `Storage::write_execution_results` method has also been corrected to not overwrite good values with empty collections. Closes #4255. Closes #4268. Co-authored-by: Fraser Hutchison <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into release-1.5.2-alt. It will not be retried. Additional information: {"message":"You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two separate issues:
transfers_db, causing the JSON-RPCchain_get_block_transfersto report the block's transfers asnullrather than[]transfers_dbwould be overwritten with an invalid empty collection, causing the JSON-RPCchain_get_block_transfersto report the block's transfers as[]rather then the correct valueTh fix is to have
Storagereconstitute the correct value when reading fromtransfers_dbif it encounters a missing value or an empty collection, and store the corrected value before returning it. TheStorage::write_execution_resultsmethod has also been corrected to not overwrite good values with empty collections.Closes #4255.
Closes #4268.