refactor(home-manager/firefox): factor out options into submodules#670
Open
getchoo wants to merge 1 commit into
Open
refactor(home-manager/firefox): factor out options into submodules#670getchoo wants to merge 1 commit into
getchoo wants to merge 1 commit into
Conversation
different-name
suggested changes
Aug 4, 2025
Contributor
different-name
left a comment
There was a problem hiding this comment.
Otherwise LGTM, haven't had the chance to test it yet
| mkFirefoxModule = | ||
| args: | ||
|
|
||
| lib.modules.importApply ./mkFirefoxModule.nix ( |
Contributor
There was a problem hiding this comment.
Is the reason for separating this out into a new file so that it could be imported & used elsewhere? (even if it's external)
Member
Author
There was a problem hiding this comment.
It's more so to just keep each file simple
It felt kinda weird having such a massive function, and practically two cases of setting config. This is as opposed to now where mkFirefoxModule is written mostly just like a regular module, and the generation magic happens in this default.nix
Along with separating our `mkFirefoxModule` function, this should help cleanup the module as whole, while also making it much more understandable
cdebf87 to
b141cde
Compare
different-name
approved these changes
Aug 5, 2025
Contributor
different-name
left a comment
There was a problem hiding this comment.
haven't tested this, but looks good to me! thank you again getchoo!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along with separating our
mkFirefoxModulefunction, this should helpcleanup the module as whole, while also making it much more
understandable
CC @different-name