carryforward flag switch #1126
Draft
carryforward flag switch #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
==========================================
- Coverage 87.85% 79.77% -8.08%
==========================================
Files 69 69
Lines 13515 13491 -24
==========================================
- Hits 11873 10763 -1110
- Misses 1642 2728 +1086
|
|
This did not work as I expected. I'll look into it! After a bit of research, it seems like I may have to add something like this: https://docs.codecov.com/docs/commit-status#flag_coverage_not_uploaded_behavior |
00430ee to
4e74c2e
Compare
|
What is the status on this? |
|
Hi! This is on the back burner until I address #1077 is addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns the method filter flag to "true". This completes the carryforward initial implementation, ensuring coverage can remain accurate as we filter tests. Allows the methods tests to only run when a file in the methods folder has changed #1086 , but ensure the previous methods coverage report is carried forward and uploaded to codecov if it hasn't been regenerated for the current pull request ( #1101 and this pull request).