Codecov Report

❌ Patch coverage is 16.66667% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.89%. Comparing base (04b73bb) to head (7ac7442).
⚠️ Report is 9 commits behind head on master.

@@            Coverage Diff             @@
##           master    #1675      +/-   ##
==========================================
- Coverage   82.02%   81.89%   -0.13%     
==========================================
  Files          75       75              
  Lines       15914    15943      +29     
==========================================
+ Hits        13053    13057       +4     
- Misses       2861     2886      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

For this PR could you check out the Turbomole parser and see how multiple files are handled. That might be a better way to handle this situation (a human readable outputfile and a binary file)

For this PR could you check out the Turbomole parser and see how multiple files are handled. That might be a better way to handle this situation (a human readable outputfile and a binary file)

Hi Shiv, I had some issues with the file wrapper when trying to parse binary files - I think the extract function should be avoided for binaries, since we don't want to read them line-wise (please correct me if I am wrong here) - if I am seeing it correctly, the turbomole parser sorts the files to deal with them using the parse function, which uses the extract function. Putting my code for the .h5 binaries into the after_parsing function was the easiest working solution. Should I consider a different function?