Fix broken configuration watching #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$scope.$watch() only works on single expressions, not arrays. Instead, use $scope.$watchGroup(). As this functionality was introduced in Angular.js 1.3, also bump the minimum dependency and the version used in the demo to that version. This was found over in https://github.com/nebulous/infinitude and was causing the dial to display incorrectly when using an expression for scaleMax that wasn't ready when the dial was first drawn.
mamarley
added a commit
to mamarley/infinitude
that referenced
this pull request
Mar 1, 2022
-Upgrade angular.js and related libraries to 1.8.2 -Switch to new API for $http response -Stop using the "!" hash prefix -Drop json3 (no remotely-modern browsers need this anymore) -Drop es5-shim (no remotely-modern browsers need this anymore) -Upgrade jquery to 3.6.0 -Upgrade bootstrap to 3.4.1 -Add override for bootstrap.css since it was removed from bootstrap's bower.json -Upgrade bundled glyphicons-halflings to match bootstrap version -Upgrade c3 to 0.7.20 -Upgrade angular-timeago to 0.4.6 -Drop ng-knob (unused) -Upgrade angular-chart.js to 1.1.1 ngTimepicker claims to be incompatible with angular.js above 1.4.x, but my testing reveals that it works fine, at least in this application. This also cherry-picks cdjackson/angular-dialgauge#12 (which fixes nebulous#24) and cdjackson/angular-dialgauge#11 (which fixes an issue introduced by nebulous@6dd47b6 where the scaleMax value for the CFM dial would sometimes not be set correctly on page load, resulting in no bar being displayed.
mamarley
added a commit
to mamarley/infinitude
that referenced
this pull request
Mar 1, 2022
-Upgrade angular.js and related libraries to 1.8.2 -Switch to new API for $http response -Stop using the "!" hash prefix -Fix controllers getting loaded multiple times by loading MainCtrl once for the entire body and not loading controllers in app.js -Drop json3 (no remotely-modern browsers need this anymore) -Drop es5-shim (no remotely-modern browsers need this anymore) -Upgrade jquery to 3.6.0 -Upgrade bootstrap to 3.4.1 -Add override for bootstrap.css since it was removed from bootstrap's bower.json -Upgrade bundled glyphicons-halflings to match bootstrap version -Upgrade c3 to 0.7.20 -Upgrade angular-timeago to 0.4.6 -Drop ng-knob (unused) -Upgrade angular-chart.js to 1.1.1 ngTimepicker claims to be incompatible with angular.js above 1.4.x, but my testing reveals that it works fine, at least in this application. This also cherry-picks cdjackson/angular-dialgauge#12 (which fixes nebulous#24) and cdjackson/angular-dialgauge#11 (which fixes an issue introduced by nebulous@6dd47b6 where the scaleMax value for the CFM dial would sometimes not be set correctly on page load, resulting in no bar being displayed.
nebulous
pushed a commit
to nebulous/infinitude
that referenced
this pull request
Mar 5, 2022
-Upgrade angular.js and related libraries to 1.8.2 -Switch to new API for $http response -Stop using the "!" hash prefix -Fix controllers getting loaded multiple times by loading MainCtrl once for the entire body and not loading controllers in app.js -Drop json3 (no remotely-modern browsers need this anymore) -Drop es5-shim (no remotely-modern browsers need this anymore) -Upgrade jquery to 3.6.0 -Upgrade bootstrap to 3.4.1 -Add override for bootstrap.css since it was removed from bootstrap's bower.json -Upgrade bundled glyphicons-halflings to match bootstrap version -Upgrade c3 to 0.7.20 -Upgrade angular-timeago to 0.4.6 -Drop ng-knob (unused) -Upgrade angular-chart.js to 1.1.1 ngTimepicker claims to be incompatible with angular.js above 1.4.x, but my testing reveals that it works fine, at least in this application. This also cherry-picks cdjackson/angular-dialgauge#12 (which fixes #24) and cdjackson/angular-dialgauge#11 (which fixes an issue introduced by 6dd47b6 where the scaleMax value for the CFM dial would sometimes not be set correctly on page load, resulting in no bar being displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$scope.$watch() only works on single expressions, not arrays.
Instead, use $scope.$watchGroup(). As this functionality was
introduced in Angular.js 1.3, also bump the minimum dependency and
the version used in the demo to that version. This was found over
in https://github.com/nebulous/infinitude and was causing the dial
to display incorrectly when using an expression for scaleMax that
wasn't ready when the dial was first drawn.