Fix connection retry with purge option at startup (#10102)#10114
Draft
harshang03 wants to merge 1 commit intocelery:mainfrom
Draft
Fix connection retry with purge option at startup (#10102)#10114harshang03 wants to merge 1 commit intocelery:mainfrom
harshang03 wants to merge 1 commit intocelery:mainfrom
Conversation
When --purge is used, purge was called in Worker.on_start() before the Consumer established the broker connection, so it failed immediately instead of respecting broker_connection_retry_on_startup. - Defer purge until after Consumer's Connection step has connected (with retry). Run purge from Connection.start() when controller.purge is set, using the established connection. - Add purge_messages_with_connection() and _do_purge() on Worker so purge can run with an existing connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --purge is used, purge was called in Worker.on_start() before the Consumer established the broker connection, so it failed immediately instead of respecting broker_connection_retry_on_startup.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Fixes #10102
Summary
With
--purge, the worker called purge inon_start()before the Consumer had a broker connection, so it failed immediately instead of usingbroker_connection_retry_on_startup. Purge now runs after the Consumer’s Connection step has established the connection (with retry), using that connection.Changes
on_start(). Addedpurge_messages_with_connection(connection)and_do_purge(connection)so purge can run with an existing connection.c.connect(), ifc.controller.purgeis set, callc.controller.purge_messages_with_connection(c.connection).