mgr/dashboard: Add DHCHAP controller key to NVME host commands#67569
mgr/dashboard: Add DHCHAP controller key to NVME host commands#67569
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for DHCHAP (Diffie-Hellman Challenge Handshake Authentication Protocol) controller keys to NVMeoF host commands in the Ceph dashboard. DHCHAP provides bidirectional authentication for NVMe over Fabrics connections, and controller keys enable the subsystem (controller) to authenticate itself to the host, complementing the existing host-to-controller authentication.
Changes:
- Added
dhchap_controller_keyparameter to the host creation endpoint, allowing controller keys to be set when adding hosts to NVMeoF subsystems - Implemented two new API endpoints for managing controller keys: change_controller_key and del_controller_key
- Extended data models to include
dhchap_controller_originfield in both Connection and Host objects, with normalization logic to format enum values for display - Updated OpenAPI specification with three new endpoints and additional property definitions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/pybind/mgr/dashboard/openapi.yaml | Added dhchap_controller_key to POST /host endpoint schema, plus three new PUT endpoints for controller key management (change_controller_key, del_controller_key, del_key) |
| src/pybind/mgr/dashboard/model/nvmeof.py | Added nqn field to Connection model and dhchap_controller_origin field to both Connection and Host models to support controller key tracking |
| src/pybind/mgr/dashboard/controllers/nvmeof.py | Implemented new controller key management endpoints, added helper functions for enum key normalization, and updated existing endpoints to handle controller keys |
Fixes: https://tracker.ceph.com/issues/74939 Signed-off-by: Gil Bregman <[email protected]>
|
This is an automated message by src/script/redmine-upkeep.py. I have resolved the following tracker ticket due to the merge of this PR: No backports are pending for the ticket. If this is incorrect, please update the tracker Update Log: https://github.com/ceph/ceph/actions/runs/22567997620 |
|
@gbregman is this something we can backport to tentacle? if so, shall we have a backport PR as well? |
mgr/dashboard: Add DHCHAP controller key to NVME host commands.
Fixes: https://tracker.ceph.com/issues/74939
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e