BUG: lib/pipeline: use blmove only if redis-py supports it #2240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BRLPOPLPUSH is deprecated, but BLMOVE can only be used if the redis python client does support it, ie. >= 4.1.2 fixes #2233
Contributor
Author
|
@kamil-certat could you please review this PR? |
aaronkaplan
approved these changes
Feb 2, 2023
Member
aaronkaplan
left a comment
There was a problem hiding this comment.
Makes sense, reviewed. looks good! Thanks for the contribution :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BRLPOPLPUSH is deprecated, but BLMOVE can only be used if the redis
python client does support it, ie. >= 4.1.2
fixes #2233