-
Notifications
You must be signed in to change notification settings - Fork 11
Improve disambiguation in contig stitcher #1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add reads_count=None to all GenotypedContig instantiations in test cases - Update expected CSV output to include reads_count column - Ensure all 406 contig stitcher tests pass with new field
- Add optional reads_count field to track read counts per contig - Implement proportional distribution when splitting contigs in cut_query() - Set reads_count to None when combining contigs in munge() - Update AlignedContig.make() to preserve reads_count field - Initialize reads_count=None in fasta_to_csv and read_contigs() - Add reads_count column to CSV output in write_contigs() - Update plot_contigs.py to include reads_count when creating fake Contig objects
Keep reads_count as internal-only field by removing it from the CSV output in write_contigs(). The field is still tracked internally for proportional distribution during contig operations.
- Add read_remap_counts() to parse remap_counts.csv and extract read counts - Update read_contigs() to accept contig_read_counts dict and populate reads_count - Make remap_counts_csv a required parameter for contig_stitcher() - Update sample.py to pass unstitched_remap_counts_csv to contig_stitcher - Update main() CLI to require remap_counts argument - Create test data file exact_parts_contigs_remap_counts.csv - Update tests to pass remap_counts parameter - Fix expected output file to match new CSV format without reads_count column This enables the contig stitcher to track read counts from the initial remap step (before stitching) for proper proportional distribution when splitting contigs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1427 +/- ##
==========================================
+ Coverage 86.82% 87.30% +0.48%
==========================================
Files 29 28 -1
Lines 7466 7460 -6
==========================================
+ Hits 6482 6513 +31
+ Misses 984 947 -37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.