Merged
Conversation
…nt not unsigned int!)
…d to store a virtual function table pointer
Member
There was a problem hiding this comment.
if you cannot ensure that there will be no subclasses, the destructor should be virtual - especially for abstract classes, they obviously are intended for further subclassing. even if subclasses have no explicit destructor please provide the destructor as virtual for abstract classes.
… the need to store a virtual function table pointer" This reverts commit 0be8483.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. First of all, I really like the glbinding code. It's sleek. I have found three small things I would like to change though. These are:
CallbackMaswas casted everywhere to an unsigned int. i changed that and also reduced the size to an unsigned charAbstractFunctionhad a virtual destructor, which is unnecessary. I removed it so that 2787 Function objects need less memory ;)