Changed Assertion.NaN to a strict implementation as defined in ES6 #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relies on an ES6 polyfill for previous Javascript versions
lib/chai/core/assertions.js
Outdated
There was a problem hiding this comment.
Missing a backtick here? NaN` should be NaN``
as discussed in PR chaijs#507 and proposed by @thefourtheye
|
Sorry @thefourtheye this PR slipped the net for a while. It's a bit outdated now, could you pretty please rebase and I'll look toward merging it 😄 |
|
@keithamus #508 has been landed already |
|
Doi, you're totally right. Thanks for that. I'll close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on an ES6 polyfill for previous Javascript versions
Fixes #498