Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: PhantomJS 1.x incompatibility #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2017
Merged

fix: PhantomJS 1.x incompatibility #966

merged 1 commit into from
May 8, 2017

Conversation

meeber
Copy link
Contributor

@meeber meeber commented May 7, 2017 •
edited
Loading

  • Addresses Plugin issues with Chai v4 #890 (comment)
  • Although I'm not crazy about adding a workaround in Chai for a 3rd party library, in this particular case it feels like a low-cost solution to allow Chai to continue supporting PhantomJS 1.x until plugins have had a chance to upgrade.

@keithamus
Copy link
Member

LGTM 👍. I'll leave the merge for another reviewer (+ @lucasfcosta, @shvaikalesh, @vieiralucas)

@lucasfcosta
Copy link
Member

LGTM. I don't think this will ever happen in any other environment, but does make things safer anyway.

@lucasfcosta lucasfcosta merged commit f3adfd9 into chaijs:master May 8, 2017
@meeber meeber mentioned this pull request May 8, 2017
Closed
@lucasfcosta lucasfcosta mentioned this pull request May 10, 2017
Closed
@renovate-bot renovate-bot mentioned this pull request May 26, 2017
Merged
@renovate renovate bot mentioned this pull request Jul 7, 2017
Closed
@meeber meeber deleted the fix-phantomjs-incompatibility branch August 6, 2017 13:49
@renovate renovate bot mentioned this pull request Feb 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meeber @keithamus @lucasfcosta