docs: fix doc comments for clog.Logger#36
Merged
Conversation
This updates doc comments and parameter names for the Logger type to be friendlier to docs-aware editors, specifically by: - Fixing when method name in doc comment did not match the method name - Using "msg" instead of "format" to align with the stdlib for when log messages are not formats - Updating to explain how the variadic args params are used Signed-off-by: Dan Luhring <[email protected]>
imjasonh
approved these changes
Apr 23, 2025
wlynch
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates doc comments and parameter names for the Logger type to be friendlier to docs-aware editors, specifically by:
argsparams are used