fix(ci): disable the Go cache in the signed-release flow#105
Merged
cpanato merged 1 commit intoJun 25, 2026
Merged
Conversation
The release job's actions/setup-go enables the Go module + build cache by default. The Go build cache stores compiled objects keyed by input hash and is trusted on a cache hit without re-verifying the output against source (go.sum covers module downloads, not the build cache), so a cache poisoned by a less-trusted run (e.g. the pull_request-triggered build-snapshot job, which shares the go.sum-derived cache key) could be restored into the signed-release build and contaminate published artifacts. Set cache: false so the release build pulls no PR-writable cache (zizmor cache-poisoning, release.yaml). Refs: PSEC-923
egibs
approved these changes
Jun 25, 2026
cpanato
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the GitHub Actions hardening in #104. Workflow-config only — no
application code is touched.
release.yaml'sactions/setup-goenables the Go module + build cache bydefault. The Go build cache stores compiled objects keyed by an input hash
and is reused on a cache hit without being re-verified against source —
go.sumcovers module downloads, not the build cache. So a cache poisoned by a
less-trusted run (e.g. the
pull_request-triggeredbuild-snapshotjob, whichshares the same
go.sum-derived cache key) could be restored into the signedrelease build and contaminate published artifacts.
This sets
cache: falseon the release job'ssetup-gostep, so the signedrelease compiles from clean, checksum-verified module downloads and consumes no
PR-writable cache.
Refs: PSEC-923