Fix issue with bumping packages without package.json#version#705
Fix issue with bumping packages without package.json#version#705
package.json#version#705Conversation
🦋 Changeset detectedLatest commit: 42f8b3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 42f8b3b:
|
| expect(changesetDir).toContain(".ignored-temporarily.md"); | ||
| }); | ||
|
|
||
| it("should throw an error if a package.json is missing the name field", async () => { |
There was a problem hiding this comment.
This is not a new test - I've only found an old fixture that was currently unused and I've thought that it would be nice to reintroduce a test for this (as the original test for it was moved to manypkg)
emmatown
left a comment
There was a problem hiding this comment.
Making it 0.0.0 if there's no version feels like weird behavior to me. I feel like I'd rather have an error?
That is also an option I've considered - it would be more of a breaking change though, especially for snapshot releases as previously those would be successfully and "correctly" published as I'm OK with throwing though - if we face any backlash we can always reconsider. |
34fbdd7 to
42f8b3b
Compare
|
any idea if this is still relevant ? |
|
I'm running into this exact issue, can we ping someone who can merge this ? @emmatown ? |
No description provided.