Improve the connection instructions landing page for VS Code (SSHD) #590
Conversation
Signed-off-by: Roland Grunberg <[email protected]>
|
Click here to review and test in web IDE: |
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-590-amd64 |
- Add CSS styling for code blocks, as well as a copy feature - Specify the namespace for oc port-forward (-n) - Move private key permission warning to listing of the key - Move instructions about "VS Code" SSH extension - Make it more clear the example path to private key should be replaced - Link to the "Command Line Tools" page and the "Token Request" page - Adapt paths based on operating system (windows, linux-based) - Ensure private key code block is displayed with newline prior to EOF Signed-off-by: Roland Grunberg <[email protected]>
ff8788f to
822ebcb
Compare
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-590-amd64 |
azatsarynnyy
left a comment
There was a problem hiding this comment.
To test the PR, I:
- took the editor image built by the GH workflow on this PR (quay.io/che-incubator-pull-requests/che-code:pr-590-amd64)
- put it to the gist with the editor definition taken from https://github.com/eclipse-che/che-operator/blob/main/editors-definitions/che-code-sshd-next.yaml
- run a workspace with the provided editor https://gist.githubusercontent.com/azatsarynnyy/56a07b64fbd13fac38844baee005971f/raw/90fedc6d006ea51d89d0632c1eb5e375c7355b72/editor-over-ssh
Got the following errors:
I tried it with a few different samples.
|
Thanks for trying this! The pull request job doesn't currently deploy the image. It only happens on push : che-code/.github/workflows/pull-request-check.yml Lines 155 to 159 in 882ca6b Also, the following change will be needed into the editor definition : - - "nohup /entrypoint.sh & nohup /sshd.start & nohup node /opt/www/server.js & tail -f /dev/null"
+ - "nohup /entrypoint.sh & nohup /sshd.start & pushd /opt/www/ && nohup node /opt/www/server.js & tail -f /dev/null"
|
azatsarynnyy
left a comment
There was a problem hiding this comment.
Thanks @rgrunber for noticing this. I used the wrong image.
It works as expected, taking into account your comment above
Fixes https://issues.redhat.com/browse/CRW-9547
Note: the containers that authorized the given keys have been destroyed
Before
After
This PR should be merged with eclipse-che/che-operator#2062 .