Added codec plugin implementation #671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- encode/decode now has their own Handler trait functions, no longer relies on js module functions to run - rquickjs: now uses call function rather than eval_with_option, to allow id/name functions with exports to be used in js plugin file - encodeDownlink/decodeUplink now needs the export keyword
…nctions & plugins
|
I'm sorry to say, but I don't see this fit in well within ChirpStack. The purpose of the device-profile templates is more or less overlaps with the need described in this PR. I got sidetracked with some customer projects, but I'm planning to pick up the work on https://github.com/chirpstack/lorawan-device-profiles soon and fully integrate this in ChirpStack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables plugin utilization for the payload codec encode/decode functions rather than using javascript directly in the chirpstack panel code editor.
This streamlines the process of CI/CD for codecs as well as easy management/replication of development, staging & production environments. This implementation is strongly inspired from the already existing ADR algorithm plugin feature. Tested with 4.12.0. Default passthrough plugin is implemented if codec plugin is used in the device profile but no custom plugins are defined in the chirpstack configuration file: uplink and downlink payloads is passed as-is with no modifications.