Cipherstash client 0.31.1#347
Merged
Merged
Conversation
9fea460 to
0ee7efd
Compare
coderdan
approved these changes
Jan 10, 2026
tobyhede
commented
Jan 10, 2026
| } | ||
|
|
||
| pub fn close_statement(&mut self, name: &Name) { | ||
| debug!(target: CONTEXT, client_id = self.client_id, statement = ?name); |
Contributor
Author
There was a problem hiding this comment.
Not actually the cause of the problem, but worth adding anyway.
Without this, named prepared statements are retained indefinitely.
We haven't seen issues with not closing before because:
- statement collection is bound to the life connection, so cleaned up on the normal pool life cycle
- most people are not actually using "real" prepared statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to cipherstash-client 0.31.1
Add close_statement function.