This repository was archived by the owner on Jan 27, 2023. It is now read-only.
check if attribute is encrypted before checking type and add test#73
Merged
Conversation
freshtonic
approved these changes
Aug 25, 2022
freshtonic
left a comment
Contributor
There was a problem hiding this comment.
This looks really great, feel free to merge once it works with Lockbox.
coderdan
approved these changes
Aug 25, 2022
coderdan
left a comment
Contributor
There was a problem hiding this comment.
Some stylistic suggestions but otherwise LGTM.
c7d690d to
2715113
Compare
freshtonic
pushed a commit
that referenced
this pull request
Dec 21, 2022
check if attribute is encrypted before checking type and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where incorrect indexes are being created for anything other than a string type.
This is due to active record setting the type for all encrypted attributes to text.
More info here https://cipherstash.slack.com/archives/C01G7UGNQ3U/p1661470867621559
I have tested out Lockbox, and this doesn't have the same issue. The setup includes a step where you specify the type on the encrypted field in the model. In ActiveStash, it comes through as an ActiveModel type, with the actual type.