V0.1.0 #21
Merged
V0.1.0 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 13, 2014 20:30
This commit removes all of the console.logs that we had around. It also sets the default behavior of the lib to keep searching for qrcodes after it encountered one, and not just search once - in the next commit searching once will be enabled by an argument. The method setDecoderCallback is removed as we now set the result callback from the prepareVideo (and prepareImage later). There is also a bit of refactor to package.json and gulpfile for a better build process. fixes #14
Owner
Author
|
Although not testing for a bunch of browsers, it is testing for the latest now (currently integrated with travis CI). As i am not completly aware of sauce labs limits for open source plans, i'll stick with this for now and call broader browsers tests latly (not from the CI). This will be on its own issue |
Owner
Author
|
Although tests fail because of sauce, they are running well on chrome/firefox latest, which is our current targets now. |
cirocosta
pushed a commit
that referenced
this pull request
Sep 15, 2014
This was referenced Sep 15, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been planning this for some time but had not the time to do it.
In v0.1.0, as exposed on some issues, will contain:
QCodeDecoder(it wasQRCodeDecoder)console.logjshint.rcgulp buildandgulp hintprepareImagemethod so that one can decode directly from an imagedecodeImagemethodsetDecoderCallbackmethodonceargument for thedecodeFromCameramethodprepareCanvasas this is just used internallydecodeFromVideomethod