Fix exception email parameters#4831
Merged
Merged
Conversation
Zharktas
approved these changes
Jun 5, 2019
Member
Zharktas
left a comment
There was a problem hiding this comment.
I totally should have made those tests when you asked them. 😂
Author
|
Cheers for reviewing this. I'll let one of the others merge. No worries about a test - this config only happens if not running under test! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4830
Proposed fixes:
Fixes SMTPHandler "mailhost" parameter format. This is needed when you configure exception emails (and don't specify the SMTP port number).
Features:
Please [X] all the boxes above that apply