4420 fix org and group dataset counts#4987
Merged
smotornyuk merged 2 commits intoSep 23, 2019
Merged
Conversation
Contributor
Author
|
@smotornyuk Please review this if you get a chance. It's much simpler (and better) than the previous PR. :) |
Member
|
Yep, now it's just awesome:) Thank you for this fix |
HobieCat
added a commit
to lynxlab/ckan
that referenced
this pull request
Jun 22, 2020
…set-counts 4420 fix org and group dataset counts (cherry picked from commit 1e70c73)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4420
Proposed fixes:
When dictizing a group or organization and including the group's packages or package count, we need to search only for packages in that group. Otherwise the group/org index page shows that all groups/orgs have the total number of datasets for the whole CKAN instance.
Features:
Please [X] all the boxes above that apply