[#5152] Fix wrong resource URL after ValidationErrors#5153
Merged
Conversation
…Error Also add a custom error that we can use to show a warning in the template that users need to resubmit the file
The previously selected File is lost and it's easy to miss it, so add a little warning under the File button warning users to resubmit it
Otherwise when using errors it is shown on the error summary on top when using scheming
amercader
added a commit
that referenced
this pull request
Apr 3, 2020
This is an adapted commit of PR #5153
Member
Author
|
Ported an adapted version to |
fostermh
pushed a commit
to cioos-siooc/ckan
that referenced
this pull request
Sep 10, 2021
This is an adapted commit of PR ckan#5153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5152
Proposed fixes:
Clears the
uploadandurl_typefields if there is a validation error to avoid submitting the file name.Adds a warning for users if they had previously selected a file for upload, as it's easy to miss it, creating an empty resource:
Happy to change the language being used if it doesn't seem clear enough