I've updated everything single place I was managed to locate by now. As for tests - I'm not sure if just visiting all possible pages and checking all the URLs related to dataset/resource views would do the thing... any idea on this account?

Hi,

I updated my base.html accordingly, however, I receive this error:
GenerationException: url_for can only return a string, got unicode instead: agrihub_resource.read?id=parcel_llkkss8320000261

is this due to python version? or what?
How this can be solved for ckan 2.8?

Best regards
Mani

Hi, @MandanaMoshref .
This change won't work for CKAN v2.8 as it has quite a different implementation of controllers. Actually, there is only one package controller in v2.8, whereas in v2.9 it was replaced by two blueprints - dataset and resource.

Thus, this PR neither can be cherry-picked nor backported into v2.8 and the only thing you can do - manually re-define a bunch of templates and package routes.

Generally, before v2.9, any trivial changes to metadata schema were assuming that you are still working with Dataset - i.e. it should be safe to use all the same routes and templates(unless you are using IDatasetForm directly, not via ckanext-scheming). If you are going to create some entity, that behaves in a completely different way(ckanext-scheming) - you should define a custom controller with custom routes in addition to changes to metadata schema. This means, for such purpose you shouldn't rely only on ckanext-scheming.
In v2.9 these ideas were re-thinked and we decided that different package types should be more distinct - that's why I'm working on current PR. But this is a big change to the ideas of "what dataset is" and such changes cannot be simply applied to previous CKAN versions because it will only produce more bugs.

Does this change let plugins override the views for specific dataset types?

Previously it didn't, but when you mentioned it, I've realized that change required for supporting extendible blueprints is quite trivial, so I've included it in the last commit. Here's the link, in case I'll add some style fixes before you'll have time to review changes: c832174

@smotornyuk this is great work. Good to merge?

It will be really great if this PR will be merged and available in v2.9(we have a few projects that are currently using custom CKAN fork because this change is essential for their workflow). So, if you have no objections and or any ideas as to some additional improvements that can be useful in conjunction with ckanext-scheming - let's merge it