Improvement: Add text to mobile nav button.#5555
Merged
Merged
Conversation
Add aria attribute and accessible screen reader text to the mobile nav button as per BootStrap 3 docs. https://getbootstrap.com/docs/3.3/components/#navbar
amercader
reviewed
Aug 25, 2020
| <div class="navbar-right"> | ||
| <button data-target="#main-navigation-toggle" data-toggle="collapse" class="navbar-toggle collapsed" type="button" aria-label="expand or collapse"> | ||
| <button data-target="#main-navigation-toggle" data-toggle="collapse" class="navbar-toggle collapsed" type="button" aria-label="expand or collapse" aria-expanded="false"> | ||
| <span class="sr-only">Toggle navigation</span> |
Contributor
Author
|
Good call, will do when I get back.
…On Tue., Aug. 25, 2020, 9:10 a.m. Adrià Mercader ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ckan/templates/header.html
<#5555 (comment)>:
> @@ -66,7 +66,8 @@
{% endif %} {% endblock %}
<div class="container">
<div class="navbar-right">
- <button data-target="#main-navigation-toggle" data-toggle="collapse" class="navbar-toggle collapsed" type="button" aria-label="expand or collapse">
+ <button data-target="#main-navigation-toggle" data-toggle="collapse" class="navbar-toggle collapsed" type="button" aria-label="expand or collapse" aria-expanded="false">
+ <span class="sr-only">Toggle navigation</span>
This should be translated
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5555 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGMI3KIM2UXMKNBGAOQIPLSCOZ4TANCNFSM4QHSP4MQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add aria attribute and accessible screen reader text to the mobile nav button as per BootStrap 3 docs.
https://getbootstrap.com/docs/3.3/components/#navbar
Fixes #
Proposed fixes:
Make mobile nav button more accessible. Backport to 2.8 would be nice.
Features:
Please [X] all the boxes above that apply