Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[#5820] fix invite user with existing email error#5880

Closed
mutantsan wants to merge 1 commit into
ckan:masterfrom
mutantsan:5820-invite-user-with-existing-email
Closed

[#5820] fix invite user with existing email error#5880
mutantsan wants to merge 1 commit into
ckan:masterfrom
mutantsan:5820-invite-user-with-existing-email

Conversation

@mutantsan
Copy link
Copy Markdown
Contributor

Fix for issue #5820
I've added validators and catch the ValidationError.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@pdelboca
Copy link
Copy Markdown
Member

This one looks good @amercader @wardi @mutantsan!

image

@amercader amercader assigned amercader and unassigned pdelboca Jun 2, 2021
@amercader
Copy link
Copy Markdown
Member

This looks great @mutantsan ,can you fix the conflicts so I can merge? Cheers

@amercader
Copy link
Copy Markdown
Member

Sorry @mutantsan still some failures

@amercader
Copy link
Copy Markdown
Member

@mutantsan I tried to fix the failures as it looked like a straight forward missing var but I'm still getting some failures after fixing that:

https://app.circleci.com/pipelines/github/ckan/ckan/2276/workflows/bbc52af2-a283-42ac-9bbf-c42aa59493fe/jobs/10018/tests#failed-test-1

My changes:

https://github.com/ckan/ckan/compare/mutantsan-5820-invite-user-with-existing-email

@mutantsan mutantsan force-pushed the 5820-invite-user-with-existing-email branch from 5042731 to 338f08a Compare September 14, 2021 11:07
@mutantsan
Copy link
Copy Markdown
Contributor Author

Sorry, @amercader , that's my fault. I had to fix it immediately.
But I don't understand what are those failed tests. I don't have these errors locally :(

@amercader
Copy link
Copy Markdown
Member

@mutantsan I re-run the tests and they passed: https://app.circleci.com/pipelines/github/ckan/ckan/2810/workflows/d0cb749a-9b79-4d7c-af32-b70e34daff04

If you fix the conflicts I'll merge this and backport it

@amercader
Copy link
Copy Markdown
Member

This was merged to master already (5708fc2), I've backported it to 2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants